Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uic spain #1341

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Uic spain #1341

merged 5 commits into from
Sep 12, 2024

Conversation

ConscritNeuneu
Copy link
Member

Fix various locations in Spain. See the commits for details.

@ConscritNeuneu
Sestao-Urbinaga is a Metro Bilbao stop
2f0c28f 
It has no published UIC code
@ConscritNeuneu
Remove double Sevilla Sta Justa
a03e4cb 
24419 is the one suggestable and activated for Renfe
@ConscritNeuneu
Fix SNCF codes for Figueres
dd77d28 
They were swapped between the locality and the actual train station

- ESFRS is the city
- ESFIG is the train station
- ESFIR is Figueres – Vilafant (the stop on the high speed line)
@ConscritNeuneu
Rework Sanlúcar la Mayor
c6967b4 
27279 only was used for Busbud, moving its idenfier to 74620 and delete
27279 as it's not in use anymore.
@ConscritNeuneu
Mark Martorell Central as a child of Martorell
945c798 
74459 -> 31506
@github-actions GitHub Actions
Copy link

➖ Stations removed

— 6568 – Sevilla Santa Justa
— 27279 – Sanlúcar la Mayor

Stations changed

  • 6484 – Sestao-Urbinaga
    • ➖ sncf_id was removed, value was ESADE
    • ➖ benerail_id was removed, value was ESADE
  • 6648 – Figueres
    • sncf_id was changed from ESFIG to ESFRS
  • 10465 – Figueras (Figueres)
    • sncf_id was changed from ESFRS to ESFIG
  • 74459 – Martorell Central
    • ➕ parent_station_id was added, value is 31506
    • is_main_station was changed from f to t
    • country_hint was changed from f to t
  • 74620 – Sanlúcar la Mayor
    • ➕ distribusion_id was added, value is ESSLA
    • distribusion_is_enabled is now enabled ✅

@marionme marionme self-requested a review September 12, 2024 12:10
marionme
marionme approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@marionme marionme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marionme marionme merged commit 7e88fab into trainline-eu:master Sep 12, 2024
1 check passed
@ConscritNeuneu ConscritNeuneu deleted the uic_spain branch September 12, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionme marionme marionme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConscritNeuneu @marionme